removed inheritance from Nette\Object and added trait Nette\SmartObject#1
Open
aplitax wants to merge 5 commits intoJoseki:masterfrom
Open
removed inheritance from Nette\Object and added trait Nette\SmartObject#1aplitax wants to merge 5 commits intoJoseki:masterfrom
aplitax wants to merge 5 commits intoJoseki:masterfrom
Conversation
added trait Nette\SmartObject
Member
|
Hi! This change is not compatible with old PHP version. So to merge it, we need to set minimal supported version to PHP 5.6 or PHP 7+. So, can you also upgrade |
castamir
reviewed
May 16, 2018
| class TextAsFileResponse extends Object implements IResponse | ||
| class TextAsFileResponse implements IResponse | ||
| { | ||
| use \Nette\SmartObject; |
Member
There was a problem hiding this comment.
there are 5 spaces instead of 4
added 4 commits
October 12, 2018 13:18
added trait Nette\SmartObject
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed inheritance from Nette\Object
added trait Nette\SmartObject